fix: do not show latest version if auto-updating #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cngonzalez
requested review from
a team and
ninaandal
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
cngonzalez
force-pushed
the
sdx-1408/remove-latest-version-in-navbar
branch
from
17be1e2 to
475a485
Compare
|
Component Testing Report Updated Aug 19, 2024 9:19 PM (UTC) ✅ All Tests Passed -- expand for details
|
binoy14
approved these changes
Aug 19, 2024
cngonzalez
added a commit
that referenced
this pull request
Aug 20, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We do not want to show the latest version label to those on auto-updating studios. There are a couple of scenarios in which the current text could be confusing:
What to review
Any edge cases in which this may not be helpful.
Testing
I would like to test this! I am trying to reduce flakiness in our test suite so we can run the entire suite against auto-updating studios. Once that is done, I will write a test for this as well!